Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix download activating on empty opposing field #2148

Closed
wants to merge 1 commit into from

Conversation

ghoulslash
Copy link
Collaborator

If you send out a mon with download against an empty field (e.g. if you both faint simultaneously), download will still activate.

This PR will prevent download from activating if there are no opposing pokemon alive.

@ghoulslash ghoulslash added the category: battle-mechanic Pertains to battle mechanics label May 21, 2022
@AsparagusEduardo
Copy link
Collaborator

Tested in Gen 5:
In the described situation, download should trigger once both mon have been sent in, instead of not triggering at all
chrome_PXU1MJxqci

@AsparagusEduardo AsparagusEduardo changed the base branch from battle_engine to master August 24, 2022 04:51
@AsparagusEduardo AsparagusEduardo changed the base branch from master to dev September 10, 2022 01:33
@AsparagusEduardo AsparagusEduardo added category: battle-mechanic Pertains to battle mechanics bugfix Bugfixes and removed category: battle-mechanic Pertains to battle mechanics labels Sep 16, 2022
@AsparagusEduardo AsparagusEduardo changed the base branch from dev to dev_1.x September 16, 2022 17:30
@DizzyEggg
Copy link
Collaborator

Done in #2712

@DizzyEggg DizzyEggg closed this Feb 22, 2023
@ghoulslash ghoulslash deleted the be/download branch October 20, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants