Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked branch defines into single compatibility define #2237

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Reworked branch defines into single compatibility define #2237

merged 2 commits into from
Aug 25, 2022

Conversation

gruxor
Copy link

@gruxor gruxor commented Aug 24, 2022

Description

  • Moved existing branch defines out of their own file and into config.h
  • Single definition exists for any future compatibility checks in 3rd-party code, but old branch defines are retained for backwards compatibility with existing projects
  • Doesn't really change anything functionally, but may clear up some confusion for people who never used the repo pre-merge

Discord contact info

Crater#7777

AsparagusEduardo
AsparagusEduardo reviewed Aug 24, 2022
View reviewed changes
include/config.h Outdated Show resolved Hide resolved
@ghoulslash ghoulslash merged commit 552d1f3 into rh-hideout:master Aug 25, 2022
@gruxor gruxor deleted the compat_define branch September 24, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo left review comments

@ghoulslash ghoulslash ghoulslash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruxor @AsparagusEduardo @ghoulslash