Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation IX Moves #2467

Merged
merged 20 commits into from
Dec 11, 2022
Merged

Generation IX Moves #2467

merged 20 commits into from
Dec 11, 2022

Conversation

Bassoonian
Copy link
Collaborator

Updates the PLA moves to SV standards and adds data for the new generation IX moves.

Description

Some moves are marked as requiring a new flag that Lunos implemented as part of his gen 9 ability branch. They need to be uncommented to work. A bunch of moves are still missing custom effects because I'm not familiar enough with the battle codebase to do all of them myself and none of them have animations. Double Shock needs the correct string (it has a placeholder one because I couldn't find the one the game used and I didn't have time to test yet).

Discord contact info

Jasper#5206

Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test in-battle effects as I haven't progressed much in the game yet, so I'll leave that part for @ghoulslash to review 👀

include/config.h Outdated Show resolved Hide resolved
src/battle_tv.c Outdated Show resolved Hide resolved
src/data/text/move_descriptions.h Outdated Show resolved Hide resolved
src/data/text/move_descriptions.h Outdated Show resolved Hide resolved
src/data/text/move_descriptions.h Outdated Show resolved Hide resolved
src/data/text/move_descriptions.h Outdated Show resolved Hide resolved
src/data/text/move_descriptions.h Outdated Show resolved Hide resolved
src/data/text/move_descriptions.h Outdated Show resolved Hide resolved
src/data/text/move_descriptions.h Outdated Show resolved Hide resolved
src/data/text/move_descriptions.h Outdated Show resolved Hide resolved
@AsparagusEduardo
Copy link
Collaborator

One more thing, remember to update B_METRONOME_MOVES.

Co-Authored-By: Eduardo Quezada D'Ottone <[email protected]>
@Bassoonian
Copy link
Collaborator Author

Updated flags and addressed Eduardo's concerns/comments. It's still a bit unclear which moves are forbidden by Metronome, Sleep Talk, Instruct etc. so that data still needs to be added in later once there's more clarity

@ghoulslash ghoulslash merged commit e3e0d60 into rh-hideout:upcoming Dec 11, 2022
@AsparagusEduardo AsparagusEduardo mentioned this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants