Insomnia ability pop-up #2643
Merged
Insomnia ability pop-up #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the constant |
|
If you did not yet I'd like to test against #2626 to see if the test passes. |
I didn't. How do you do these tests? |
SBird1337
approved these changes
Feb 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2631
Changes jumpifcantmakeasleep to jumpifuproarwakes and moves the ability checks to the battlescript.
I thought it would make more sense this way, as other ability checks were already checked at the battlescript level, so it made little sense to have Insomnia/Vital Spirit checked with Uproar.