Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix After you for gen8 #2646

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Fix After you for gen8 #2646

merged 5 commits into from
Feb 16, 2023

Conversation

DizzyEggg
Copy link
Collaborator

@DizzyEggg DizzyEggg commented Feb 7, 2023

Fixes #2615

B_RECALC_TURN_AFTER_ACTIONS made After You have no effect as noticed by Alex. I added a special status so it doesn't recalculate actions if After you was used.

Also fixed one thing where After You wouldn't fail if used on a pokemon who was about to act anyway.

@ghoulslash
Copy link
Collaborator

Couldn't qaush field be used for this instead?

@DizzyEggg
Copy link
Collaborator Author

Couldn't qaush field be used for this instead?

I think there could be problems if Quash / After you were used at the same turn.

test/move_effect_after_you.c Outdated Show resolved Hide resolved
mrgriffin
mrgriffin previously approved these changes Feb 16, 2023
Copy link
Collaborator

@mrgriffin mrgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion, rename afteryou to afterYou? I'll merge this later regardless though :)

@mrgriffin mrgriffin merged commit d637ee3 into rh-hideout:upcoming Feb 16, 2023
@AsparagusEduardo AsparagusEduardo mentioned this pull request Feb 19, 2023
@DizzyEggg DizzyEggg deleted the afteryou branch June 23, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The move After you seems to be bugged
3 participants