Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Battle Anim cmds for dynamic Task, Sprite creation + Misc. Anim Fixes #2649

Merged
merged 11 commits into from
Feb 19, 2023

Conversation

ghoulslash
Copy link
Collaborator

@ghoulslash ghoulslash commented Feb 7, 2023

Cmds to create tasks and sprites that affect a dynamic number of targets

Animation Fixes:

  • fiery wrath
  • electroweb
  • heal block targeting/anim --> Another cmd was needed, createspriteontargets_onpos, because AnimSpriteOnMonPos is weird
  • Venom Drench to take average target positions into account

fixes #2650

These can eventually be used for triple battles, so rather than editing all MOVE_TARGET_BOTH anim tasks/sprite callbacks we can use these cmds in the battle anim scripts

electroweb:
electroweb

@ghoulslash ghoulslash changed the title Add Battle anim script cmds to create sprites, tasks on all targets Add Battle Anim cmds for dynamic Task, Sprite creation + Misc. Anim Fixes Feb 7, 2023
src/battle_anim.c Outdated Show resolved Hide resolved
src/battle_anim.c Outdated Show resolved Hide resolved
@ghoulslash
Copy link
Collaborator Author

implemented suggestions

@DizzyEggg DizzyEggg merged commit 4b64433 into rh-hideout:upcoming Feb 19, 2023
@AsparagusEduardo AsparagusEduardo mentioned this pull request Feb 19, 2023
@ghoulslash ghoulslash deleted the be/anims branch January 2, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heal Block only targets a single battler
2 participants