Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Battle Tests (Feb 19) #2707

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Battle Tests (Feb 19) #2707

merged 4 commits into from
Feb 21, 2023

Conversation

mrgriffin
Copy link
Collaborator

@mrgriffin mrgriffin commented Feb 19, 2023 •
edited
Loading

Move effects: Roar, Dragon Tail.
Abilities: Overgrow, Swarm, Torrent.
Hold effects: Red Card.

Fixes:

  • Dragon Tail activates Red Card if the target does not switch.
  • Dragon Tail does not print the "But it failed!" message if the target does not switch.
  • Roar is not implemented with rejection sampling.

@mrgriffin mrgriffin force-pushed the rhh-battle-tests-02-19 branch 2 times, most recently from fc0fc36 to 741c799 Compare February 19, 2023 23:18
@mrgriffin mrgriffin marked this pull request as ready for review February 19, 2023 23:18
@mrgriffin mrgriffin changed the base branch from upcoming to master February 19, 2023 23:18
@mrgriffin
Copy link
Collaborator Author

Ready for review 😁

@mrgriffin mrgriffin added the category: battle-tests Related to the automated test environment label Feb 20, 2023
DizzyEggg
DizzyEggg requested changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@DizzyEggg DizzyEggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the tests :D

data/battle_scripts_1.s Outdated Show resolved Hide resolved
include/battle.h Outdated Show resolved Hide resolved
@mrgriffin mrgriffin force-pushed the rhh-battle-tests-02-19 branch 4 times, most recently from 6db04ca to 0208edd Compare February 20, 2023 12:17
@mrgriffin
Copy link
Collaborator Author

Ready for re-review :)

@mrgriffin mrgriffin force-pushed the rhh-battle-tests-02-19 branch from 0208edd to b755d05 Compare February 21, 2023 00:54
@DizzyEggg
Copy link
Collaborator

All good for me, but the branch is set to master atm. I thought we were merging stuff first to upcoming, and then to master.

@mrgriffin mrgriffin changed the base branch from master to upcoming February 21, 2023 10:41
mrgriffin and others added 4 commits February 21, 2023 10:43
@mrgriffin
Test Overgrow, Swarm and Torrent
2eb6401
@mrgriffin
Test Roar
666e59b 
The original implementation of forcerandomswitch was biased towards
certain party members.
@mrgriffin
Test Dragon Tail
afe09e9 
Remove the "But it failed!" message if the foe cannot be switched.
@mrgriffin
Test Red Card
29c64c8 
Dragon Tail activates Red Card if the target does not switch.
@mrgriffin mrgriffin force-pushed the rhh-battle-tests-02-19 branch from b755d05 to 29c64c8 Compare February 21, 2023 10:48
@mrgriffin
Copy link
Collaborator Author

Rebased onto upcoming, as per discussion in #expansion-dev.

@DizzyEggg DizzyEggg merged commit 41e0278 into rh-hideout:upcoming Feb 21, 2023
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DizzyEggg DizzyEggg DizzyEggg approved these changes

Assignees
No one assigned
Labels
category: battle-tests Related to the automated test environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrgriffin @DizzyEggg