Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Protean / Libero when AI calculates Damage #2714

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

DizzyEggg
Copy link
Collaborator

Fixes #2155

Replaces #2281

@May8th1995
Copy link

This currently changes actual pokemon type on both sides.

image

Something like this could be done instead, I don't know any of the fancy git formatting so sorry for this just being an image.

mGBA_QhwCNjcm3G.mp4

@DizzyEggg
Copy link
Collaborator Author

DizzyEggg commented Feb 23, 2023

You're right. Good catch.

This should be merged only after #2726, because it makes the AI save the battler types, so they don't get overwritten.

@DizzyEggg DizzyEggg marked this pull request as draft February 23, 2023 10:21
@DizzyEggg DizzyEggg marked this pull request as ready for review February 27, 2023 09:34
@DizzyEggg
Copy link
Collaborator Author

Ready for review.

@DizzyEggg DizzyEggg merged commit e055456 into rh-hideout:upcoming Mar 7, 2023
@DizzyEggg DizzyEggg deleted the protean_ai branch March 7, 2023 08:34
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI doesn't account for Protean/Libero in damage calcs
3 participants