Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit long z-moves names on battle textbox #2789

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

DizzyEggg
Copy link
Collaborator

Fixes #2351

@Jaizu
Copy link

Jaizu commented Feb 27, 2023

I think this is fine but we have to be way more careful about text-windows in the future. The ideal solution should be to add a new window called zmovesmovename that uses the same with as move name 1 + move name 2.
To make it more clear, you made the text-window larger but you didnt make the next text windows start on a later baseblock.
Atm it's 12 * 2 = 24 = 0x18 in hex. Current baseblock is 0x300, move name 2 baseclock is 0x318.
To make this correct, we should make the next baseblock have a higher value, including all the other windows that start after that baseblock, otherwise we might overwrite windows in the vram.

@ghoulslash
Copy link
Collaborator

I think this is fine but we have to be way more careful about text-windows in the future. The ideal solution should be to add a new window called zmovesmovename that uses the same with as move name 1 + move name 2.
To make it more clear, you made the text-window larger but you didnt make the next text windows start on a later baseblock.
Atm it's 12 * 2 = 24 = 0x18 in hex. Current baseblock is 0x300, move name 2 baseclock is 0x318.
To make this correct, we should make the next baseblock have a higher value, including all the other windows that start after that baseblock, otherwise we might overwrite windows in the vram.

Iirc it doesn't matter because the move names on the right are drawn after those on the left, so it would only overwrite anything if your regular moves have more characters than fit in the regular window, so what you propose is technically just eating into vram unnecessarily

@DizzyEggg
Copy link
Collaborator Author

Exactly what ghoul wrote

@Jaizu
Copy link

Jaizu commented Feb 27, 2023

Ghoul is totally right, I don't know why I didn't consider wasting VRAM with my approach an issue.

@AsparagusEduardo AsparagusEduardo merged commit c6149ea into rh-hideout:upcoming Feb 27, 2023
@AsparagusEduardo AsparagusEduardo mentioned this pull request Mar 21, 2023
@DizzyEggg DizzyEggg deleted the zmoves_names branch June 23, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light That Burns The Sky's name doesn't display fully in battle box
4 participants