-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Menu improvements #2814
Debug Menu improvements #2814
Conversation
-Updated the text string used by Debug_FlagsNotSetMessage. -Renamed Debug_FlagsNotSetMessage to Debug_FlagsNotSetOverworldConfigMessage. -Added an equivalent for the battle config file called Debug_FlagsNotSetBattleConfigMessage, -DEBUG_FLAG_NO_COLLISION -> OW_FLAG_NO_COLLISION -And moved it to include/config/overworld.h, because at the end of the day it's still an overworld flag just like the other 2 already in that file. -Corrected miswritten preproc config in DebugAction_Flags_CatchingOnOff. -Updated the comment that describes the effect of DEBUG_OVERWORLD_MENU reducing the number of characters a tiny bit and fixing a typo.
Ready for review I think. I made a couple of improvements. |
For this and future PRs, I'd prefer for the Title/Description to be updated to what it fully does, to make it easier for me when I compile for the changelog :) |
I can't explain every single thing on the title though. GitHub does suggest to use 50 words or less too. |
Yeah, but instead of "Updated Debug Menu" you could write "Debug Menu Improvements" |
Description
HunarPG#2786 and I spotted some weird things in the debug menu, so I decided to go ahead and correct most of them.
Discord contact info
Lunos#4026