Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Menu improvements #2814

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Conversation

LOuroboros
Copy link
Collaborator

@LOuroboros LOuroboros commented Mar 8, 2023

Description

HunarPG#2786 and I spotted some weird things in the debug menu, so I decided to go ahead and correct most of them.

  • Updated the text string used by Debug_FlagsNotSetMessage.
  • Renamed Debug_FlagsNotSetMessage to Debug_FlagsNotSetOverworldConfigMessage.
  • Added an equivalent for the battle config file called Debug_FlagsNotSetBattleConfigMessage,
  • DEBUG_FLAG_NO_COLLISION -> OW_FLAG_NO_COLLISION
    • And moved it to include/config/overworld.h, because at the end of the day it's still an overworld flag just like the other 2 already in that file.
  • Corrected miswritten preproc config in DebugAction_Flags_CatchingOnOff.
  • Updated the comment that describes the effect of DEBUG_OVERWORLD_MENU reducing the number of characters a tiny bit and fixing a typo.
  • Added a new option to clear the PC boxes inside the debug menu's Utilities section.
  • Made DebugAction_Give_FillPC give different individual species starting with Bulbasaur instead of 420 Deoxys.
    • Made it set the Seen and Caught Pokédex flags for each of those species.
    • Made it enable the FLAG_SYS_POKEMON_GET for user's convenience.

Discord contact info

Lunos#4026

-Updated the text string used by Debug_FlagsNotSetMessage.
-Renamed Debug_FlagsNotSetMessage to Debug_FlagsNotSetOverworldConfigMessage.
-Added an equivalent for the battle config file called Debug_FlagsNotSetBattleConfigMessage,
-DEBUG_FLAG_NO_COLLISION -> OW_FLAG_NO_COLLISION
 -And moved it to include/config/overworld.h, because at the end of the day it's still an overworld flag just like the other 2 already in that file.
-Corrected miswritten preproc config in DebugAction_Flags_CatchingOnOff.
-Updated the comment that describes the effect of DEBUG_OVERWORLD_MENU reducing the number of characters a tiny bit and fixing a typo.
@LOuroboros
Copy link
Collaborator Author

Ready for review I think. I made a couple of improvements.
-Added a new option to clear the PC boxes inside the debug menu's Utilities section.
-Made DebugAction_Give_FillPC give different individual species starting with Bulbasaur instead of 420 Deoxys.
-Made it set the Seen and Caught Pokédex flags for each of those species.
-Made it enable the FLAG_SYS_POKEMON_GET for user's convenience.

@AsparagusEduardo
Copy link
Collaborator

For this and future PRs, I'd prefer for the Title/Description to be updated to what it fully does, to make it easier for me when I compile for the changelog :)

@LOuroboros
Copy link
Collaborator Author

For this and future PRs, I'd prefer for the Title/Description to be updated to what it fully does, to make it easier for me when I compile for the changelog :)

I can't explain every single thing on the title though. GitHub does suggest to use 50 words or less too.

@AsparagusEduardo
Copy link
Collaborator

I can't explain every single thing on the title though. GitHub does suggest to use 50 words or less too.

Yeah, but instead of "Updated Debug Menu" you could write "Debug Menu Improvements"

@AsparagusEduardo AsparagusEduardo changed the title Updated the debug menu Debug Menu improvements Mar 9, 2023
@AsparagusEduardo AsparagusEduardo merged commit aedf18f into rh-hideout:upcoming Mar 9, 2023
@LOuroboros LOuroboros deleted the debUG branch March 9, 2023 20:08
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants