Fix healthbox reappearing from B_ANIM_SWITCH_OUT_OPPONENT_MON #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ITCH_OUT_OPPONENT_MON
ghoulslash
added
category: battle-mechanic
AsparagusEduardo
approved these changes
May 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a battle tower tag battle for example, when
returnopponentmon1toballandreturnopponentmon2toballare called, the healthboxes reappear at the end due to the 2nd argument ofUpdateOamPriorityInAllHealthboxesbeing TRUE inCmd_endof battle anims. This PR moves thehideHpBoxesboolean to EWRAM so it can be passed to both instances of the function and fix this issue.