GetSideParty/GetBattlerParty

[mrgriffin]

Very minor change, introduces GetSideParty and GetBattlerParty for two reasonably common patterns:

-struct Pokemon *party = side == B_SIDE_PLAYER ? gPlayerParty : gEnemyParty;
+struct Pokemon *party = GetSideParty(side);

-struct Pokemon *party = GetBattlerSide(battlerId) == B_SIDE_PLAYER ? gPlayerParty : gEnemyParty;
+struct Pokemon *party = GetBattlerParty(battlerId);

[mrgriffin]

I could have added #include "battle_anim.h" to the top of this file instead of declaring GetBattlerSide. I don't really mind which approach is chosen.

[ghoulslash]

GetBattlerPartyData already exists so I think GetBattlerParty is redundant

[mrgriffin]

GetBattlerPartyData already exists so I think GetBattlerParty is redundant

I don't think they do the same thing—GetBattlerPartyData seems to return the Pokemon for the specific battler, whereas GetBattlerParty returns the whole party—that said, I think the names would be confusing, do you have a better suggestion for GetBattlerPartyData, I was thinking maybe GetBattlerPokemon or something?

[ghoulslash]

GetBattlerPartyData already exists so I think GetBattlerParty is redundant

I don't think they do the same thing—GetBattlerPartyData seems to return the Pokemon for the specific battler, whereas GetBattlerParty returns the whole party—that said, I think the names would be confusing, do you have a better suggestion for GetBattlerPartyData, I was thinking maybe GetBattlerPokemon or something?

Oh I gotcha. How about GetBattlerPartySource?

[AsparagusEduardo]

Oh I gotcha. How about GetBattlerPartySource?

"Source" doesn't really mean anything imo

[ghoulslash]

I don't care, then. This PR is simple enough to not be dragged down by semantics.

[ghoulslash]

fix conflicts