Move direct statStage boosts to use statbuffchange #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoulslash
changed the title
|
I see three direct statStage boosts still there: |
|
What is the deal with the absorbing ability config? Why would the config change whether or not the stat change occurs in the code. Also it was unclear if Simple affects Rage. Would need in game testing if possible. |
I don't know, you reviewed #2470 👀 |
|
updated for speed boost, absorbing abilities, and rage. ready for review. |
AsparagusEduardo
approved these changes
May 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future proofing stat stage boosting abilities to run through
statbuffchange. Ideally, any and all stat boosts/drops would run through this to handle any "Simple" like behavior down the line. This PR starts this process for Download, Moxie/etc