Gender differences sprites, part 1 #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added sprites for: - Pikachu/Raichu - Doduo/Dodrio - Goldeen/Seaking - Xatu - Politoed - Meditite/Medicham - Gible/Gabite/Garchomp NOTE: I had to tweak Doduo's palette file because it wasn't matching the normal one and a result Doduo's beak looked weird.
Replaced them with the ones provided by CyanSixFour because they looked better than the ones that I had.
AsparagusEduardo
requested changes
Jun 22, 2023
Edited the macros so that only base Pikachu would show different forms based on gender. Big thanks to AsparagusEduardo for helping with this.
|
Fixed and ready for review |
AsparagusEduardo
requested changes
Jun 26, 2023
There was a problem hiding this comment.
Looks good in-game, though #3051 made us realize that bit depths for some sprites were wrong.
You'll need to solve conflicts and fix the bit depths of the following sprites due to them being copied from the erroneous previous depths:
- Front Female Dodrio
- Front Female Xatu
Replaced Goldeen (female back), Politoad (female back), Medicham (female all) sprites with those provided by CyanSixFour because they looked better. Also tweaked my male Meditite back
|
Ready for re-review! Fixed conflicts and Dodrio/Xatu sprites and swapped sprites as discussed on Discord |
AsparagusEduardo
approved these changes
Jun 26, 2023
99 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First PR that adds sprites for some Pokémon with gender based differences, namely:
Pikachu and Gloom's back sprites were taken from Chaos Rush's resource; Pikachu's front was done by CyanSixFour.
Discord contact info
SubzeroEclipse#2104