Add ai delay timer

[DizzyEggg]

Adds a timer which counts how long it takes for the AI to decide which action and move to choose.
The number of frames will be displayed in the battle box replacing the "What will PKMN do" text.
Uses new config define DEBUG_AI_DELAY_TIMER

I also changed GetAiLogicData function's name to SetAiLogicDataForTurn, because it made more sense to me, but I can revert it or change to something else if needed.

Current benchmarks on upcoming are:

• 11 frames when choosing a move
• 48 frames when AI switches(note it may actually be closer to 30 or 50 depending on how many pokemon the AI party has). It takes too long, and the lag is way too noticeable, it'll be fixed in Smarter SwitchAI Mon Choices | HasBadOdds Switch Check #3253
• 45 frames in a double battle
  When building with modern these all take less frames(which is all the more reason to ditch agbcc)
  
  
  
  
  
  

[ghoulslash]

As far as ideas for making AI faster - replacing the table of AI flag functions with a table of score changes per move effect speeds things up considerably (we did this in voyager and I got 19 frames for a double battle with partner)

[ghoulslash]

Thoughts on adding the frames counter to the battle debug menu?

[DizzyEggg]

The AI one or in more general sense?

[ghoulslash]

Was thinking just adding the value to the AI Info page but that can just be a separate PR if desired. Otherwise I think this looks good now

[DizzyEggg]

Let's do it in a separate PR then

[DizzyEggg]

As far as ideas for making AI faster - replacing the table of AI flag functions with a table of score changes per move effect speeds things up considerably (we did this in voyager and I got 19 frames for a double battle with partner)

Wow, this is a huge change! Could you share with us how it looks like?

[ghoulslash]

As far as ideas for making AI faster - replacing the table of AI flag functions with a table of score changes per move effect speeds things up considerably (we did this in voyager and I got 19 frames for a double battle with partner)

Wow, this is a huge change! Could you share with us how it looks like?

On mobile and can share more later, but basically it combines all AI calcs into a single function call like so:

s16 BattleAiCalcScore(battlerAtk, battlerDef, move, moveIndex, aiflags, score)
{
  // initialize local data struct with relevant AI info
  struct AICalcData aiData;
  aiData.battlerAtk = battlerAtk:
  //Etc

  // do some generic AI calcs/flags like doubles logic, field effects, move usability, strongest move, try to faint logic, specific ability interactions

  // finally, move effect specific check
  return sAiMoveEffectFuncs[moveEffect](&aiData, score);
}

And our table is just a table of function pointers:

static s16 (*const) sAiMoveEffectFuncs[](struct AiCalcData *idata, s16 score) = {
[MOVE_EFFECT_HIT] = sAiEffectScore_Hit,
//etc
}

And each function looks like this, having individual calcs for each ai Flag

s16 sAiEffectScore_Hit(aiData, score)
{
  if (aiData.flags & AI_CHECK_BAD_MOVE) {
    // bad move logic for this effect only
  }
  // other effect specific flag checks/calcs
}

So it's a bit cumbersome but having all the AI calcs in a single function and the jump tables speeds things along nicely. Theoretically we don't need a table of functions and could keep the switch statement to just combine CheckBadMove and CheckViability though