Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant Merging Song of Retrospection (Pret merge 2023/09/26) #3347

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Sep 26, 2023

Description

SHA1 before and after merge: 71f09aa902f2469bd6c6c598888368797c765889
SHA1 after bugfixes: c159af0bf9b7cb4beaf45e0efeb93fd182d7fabe

Discord contact info

AsparagusEduardo

If you don't get the title, look it up.

GriffinRichards and others added 11 commits September 3, 2023 20:57
[LEAK-INFORMED] Add `blockBoxRS` field to `struct BoxPokemon`
fixes a potential buffer overread in TryGetAbilityInfluencedWildMonIndex.
The bug can occur if an electric type mon is in the first slots of a fishing
encounter table and the player carries a mon with the `ABILITY_STATIC` ability.
This never happens in the vanilla codebase.
[BUGFIX] for abilities affecting wild encounter tables
Add Missing Constant Usage in m4a_1
# Conflicts:
#	include/graphics.h
#	src/anim_mon_front_pics.c
#	src/data/graphics/pokemon.h
#	src/data/pokemon/level_up_learnsets.h
#	src/data/pokemon/pokedex_text.h
#	src/data/pokemon_graphics/still_front_pic_table.h
#	src/wild_encounter.c
@AsparagusEduardo AsparagusEduardo changed the title Vagrant Merging Song of retrospection (Pret merge 2023/09/26) Vagrant Merging Song of Retrospection (Pret merge 2023/09/26) Sep 26, 2023
@AsparagusEduardo
Copy link
Collaborator Author

Forgot to add the hashes.

@AsparagusEduardo AsparagusEduardo merged commit f35c5e2 into rh-hideout:upcoming Sep 26, 2023
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/upcoming/pret_merge20230926 branch September 26, 2023 11:36
@AsparagusEduardo AsparagusEduardo mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants