Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added directory for migration scripts and added item_ball migration script #3997
Added directory for migration scripts and added item_ball migration script #3997
Changes from all commits
0dd8905
8c80719
580ec16
780eb8c
925a160
83c5d2e
26c6625
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those need changing if you run it from a sub-folder right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, I just tested it in a different Emerald and it seems to work, but somebody else should check on me on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is odd. Afaik
.
is the root folder so it shouldn't work? I'll test it tomorrow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, just tested. It doesn't work. It needs to be changed to the parent directory.
Well, Idk. I guess a decision should be made here since you can run the script from the root folder
python sub-folder/script.py
. I guess it doesn't really matter but I would probably move into the scripts folder to run it if I didn't know better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are the instructions in the README. Do these instructions fail?
OR did you do:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that
python3 migration_scripts/*.py
works. I'm just saying that people will go into the sub-folder and run the script from there without reading the instructions. Which will not work.Btw is there a reason to add the executable permissions? It works fine without.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ig it's not really an important conversation. Whether you go into the folder and run the script from there or specify the correct path to it does accomplish the same thing in the end. Maybe there is a way to sneak in an Error Message if you run it from the wrong path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay.
I don't think there's a good way to make sure it runs no matter where you run the script from. I could be wrong.
If a dev doesn't read the file called
README
, and then just runs a python script without context...I'll remove the
chmod
line.An error message would is a good idea!