Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pluralName to gItems to allow the proper spelling when multiple items are received at once #4001

Merged
merged 12 commits into from
Jan 16, 2024
Merged
Prev Previous commit
Next Next commit
Created ITEM_NAME_PLURAL_LENGTH
pkmnsnfrn committed Jan 15, 2024
commit 1322564062a6788a8f3eac2ca47d7a7b85bd4505
1 change: 1 addition & 0 deletions include/constants/global.h
Original file line number Diff line number Diff line change
@@ -101,6 +101,7 @@

// string lengths
#define ITEM_NAME_LENGTH 14
#define ITEM_NAME_PLURAL_LENGTH ITEM_NAME_LENGTH + 2 // the longest plural name (ElectrcMemories) is ITEM_NAME_LENGTH + 1
#define POKEMON_NAME_LENGTH 10
#define POKEMON_NAME_BUFFER_SIZE max(20, POKEMON_NAME_LENGTH + 1) // Frequently used buffer size. Larger than necessary
#define PLAYER_NAME_LENGTH 7
2 changes: 1 addition & 1 deletion include/item.h
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ struct Item
const u8 *description;
const u8 *effect;
u8 name[ITEM_NAME_LENGTH];
u8 pluralName[ITEM_NAME_LENGTH + 2]; // allow room for potential -ies suffix
u8 pluralName[ITEM_NAME_PLURAL_LENGTH];
u8 holdEffect;
u8 holdEffectParam;
u8 importance;