-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Move Psychic Noise #4005
Adds Move Psychic Noise #4005
Conversation
Given that Psychic Noisecs effect is a secondary effect blocked by Sheer Force and Shield Dust, do you think you could encapsulate it as a move effect? If you don't feel like doing that, then you need to check for those two abilities in the script. |
will do |
reviews applied |
{ | ||
gBattlerAbility = gEffectBattler; | ||
BattleScriptPush(gBattlescriptCurrInstr + 1); | ||
gBattlescriptCurrInstr = BattleScript_AromaVeilProtectsRet; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things:
- The "proper" way to do this is to use
AbilityBattleEffects(ABILITYEFFECT_CHECK_BANK_SIDE...
. That way you don't run the risk of checking the partner's data in a single battle. - You should check ingame if there should be an Ability pop-up here. Usually when a secondary effect is blocked by an Ability (eg. Water Veil blocking burn) no Ability pop-up is shown -- the effect just doesn't happen.
- If there is supposed to be an Ability pop-up, it'll say the wrong Pokemon's Ability in the case where it's the partner's Ability that blocks it (you're setting
gBattlerAbility
togEffectBattler
regardless of the Ability holder)/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There is the function
IsAbilityOnSide
that is used forABILITY_AROMA_VEIL
. Would that suffice? - On showdown the ability pop up does show up.
- Correct. Should have been obvious 🫣
Closes #3844