Rename MgbaPrintf_ to Test_MgbaPrintf #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is small enough of a PR to be targeted to master. Also, the issue has the following notes to be addressed:
|
|
It was marked as 1.9, so I figured it had to go to upcoming. The issues you mentioned are irrelevant because we're not replacing the function, just renaming it |
|
@AsparagusEduardo can this be merged? I think the target in this case doesn't matter. |
Ok |
AlexOn1ine
approved these changes
May 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title
Issue(s) that this PR fixes
Fixes #4222
Discord contact info
bassoonian