FIx mummy and lingering aroma abilities #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..and lingering aroma. Adds tests for both.
|
can you parametrize both tests and leave a comment in the empty file that point to the test file with the tests? The dazzling tests do it like that/ |
|
Are you sure? I don't think I've seen any tests that parametrize strings. |
@AsparagusEduardo what should be done here? |
Mummy and Lingering Aroma don't replace each other Mummy doesn't replace abilities that can't be suppressed
The if/else added should be good enough |
AlexOn1ine
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) that this PR fixes
They straight up didn't work.
Discord contact info
duke5614