Added config to prevent unobtainable Pokemon from being shiny

[fdeblasio]

Description

Added P_ONLY_OBTAINABLE_SHINIES config to prevent unobtainable Pokemon (pre-Poke Balls and in Battle Pyramid) from being shiny

Discord contact info

Frankfurter0

[Sneed69]

Seems like this would cause your starter to never be shiny also.

[fdeblasio]

Seems like this would cause your starter to never be shiny also.

I think the starter gets taken care of by ScriptGiveMonParameterized in script_pokemon_util.c

[pkmnsnfrn]

imho

- //If TRUE, Pokémon that the player can't catch (such as before getting Poké Balls or in the Battle Pyramid) won't be shiny.
+ //If TRUE, Pokémon encountered when FLAG_ADVENTURE_STARTED is not set OR in the Battle Pyramid won't be shiny.

I didn't even know that flag existed until right now, so this would surprise me.

Alternatively, you could make it a flag define and the user would just use any flag for their specific game

this is not blocking feedback

[Bassoonian]

This is out of scope, but I feel like a logical analogy (one that will probably get activated a lot) is a separate config that disallows wild shiny Pokémon if your Poké Ball pocket is empty, even halfway the game. Up to you if you'd like to include it in this PR or not :)

[fdeblasio]

This is out of scope, but I feel like a logical analogy (one that will probably get activated a lot) is a separate config that disallows wild shiny Pokémon if your Poké Ball pocket is empty, even halfway the game. Up to you if you'd like to include it in this PR or not :)

I added the functionality, but I'm not thrilled with the name of the config. If anyone has any better names, I'd love some recommendations

[AsparagusEduardo]

Alternatively, you could make it a flag define and the user would just use any flag for their specific game

this is not blocking feedback

Tbh, I disagree with it being non-blocking. Flags are a lot of the time modified by the user, meaning that FLAG_ADVENTURE_STARTED might be gone in downstream hacks. I recommend implementing this as a flag define instead.

[AlexOn1ine]

I'm going to merge this. @AsparagusEduardo Please make an issue if you would like any follow up on this.