Readd missing RNG tiebreakers for speed and priority ties

[Sneed69]

Discord contact info

duke5614

[mrgriffin]

There's a Random() & 1 on this line: https://github.com/rh-hideout/pokeemerald-expansion/blob/master/src/battle_main.c#L5100. I think that line was probably intended to deal with speed ties, but actually what it does is 50% of the time say that nobody strikes first, and 50% of the time it says that battler1 strikes first? I think it should be removed to make your changes work?

EDIT: Now I think about it, maybe that explains why the test says that the algorithm is significantly biased?

[Sneed69]

Good catch. I'll see what I can do.

[Sneed69]

The current testing system does not allow for this be tested but it works in game.
WhichBattlerFaster is called 4 times per turn which when combined with the tests' fixed RNG it makes the turn order swap 0 or 4 times both which have the same results.
Perhaps it would be worth adding an RNG tag as an parameter for the function but I'm not so sure about it.