Added MB_X_Y_STAIR_WARP metatile behaviors

[pkmnsnfrn]

INCORPORATES A FEATURE BRANCH - DO NOT SQUASH!

Description

• Ported @ghoulslash's stair_warps branch to expansion

Usage

Metatile Behaviors

No tilesets within vanilla Emerald have been modified. Users will need to manually add the new metatile behaviors to the relevent metatiles.

Functionality

When player is standing on a metatile with MB_X_Y_STAIR_WARP behavior and walks towards a warp, they player's x and y position changes to simulate the player going up and down the stairs.

Testing

Clean Branch

You can recreate this branch by applying a patch or pulling the repo. From a clean version of expansion's upcoming, you can either:

Patch

wget https://files.catbox.moe/3o61ki.patch -O stair_warps.patch ; git apply stair_warps.patch ; rm stair_warps.patch

Repo

git remote add psf-expansion https://github.com/PokemonSanFran/pokeemerald-expansion/ ; git pull psf-expansion stair_warps

Manual Tests

After replicating the branch, to recreate my testing environment, you can either directly download the debug script and config file, or manually create the changes.

Download

wget https://github.com/rh-hideout/pokeemerald-expansion/commit/6ea73bb8b41615deaab776b0ffac11061228a5b6.patch -O stair_warps_testing.patch ; git apply stair_warps_testing.patch ; rm stair_warps_testing.patch ; wget https://github.com/rh-hideout/pokeemerald-expansion/commit/e44beb77fd2b34f0b4db4789b5d0ecbfcf156cf8.patch -O stair_warps_testing2.patch ; git apply stair_warps_testing2.patch ; rm stair_warps_testing2.patch

Manual Testing

• Start a New Game
• R + Start to open Overworld Debug Menu
• Utilites > Cheat Start
• R + Start to open Overworld Debug Menu
• Utilities > Warp to map warp > Group 24 > Map 7 > Warp 0
• Walk up and down every stair case
• Run up and down every stair case
• Use the Acro Bike up and down every stair case

Verified Scenarios

The video shows all the Manual Testing.

test.mp4

People who collaborated with me in this PR

This was originally written by by @ghoulslash.

Discord Contact Info

I am pkmnsnfrn on Discord.

[AlexOn1ine]

I assume this is the same pr as #4836?

[pkmnsnfrn]

I assume this is the same pr as #4836?

incorrect, they are different.

[Bassoonian]

Please solve conflicts