Triple layer metatiles

[pkmnsnfrn]

Changelog Note

• If you have made changes to any the maps in data/tilesets, you should reject the changes in Metatile migration READ DESC BEFORE MERGING #5305 and run the migration script manually.

Description

• Replaces the Dual Layer Metatile system with Triple Layer Metatile system.

Usage

Triple metatile layers allow developers to control the look and feel of all three background layers of the overworld - in pokeemerald, developers are restricted to a bottom layer and a "top / middle" layer. This does not require any input from the developer except for running the migration script.

Testing

Clean Branch

You can recreate this branch by applying a patch or pulling the repo. From a clean version of expansion's upcoming, you can either:

Patch

wget https://files.catbox.moe/x685zd.patch -O tripleLayerMetatiles.patch ; git apply tripleLayerMetatiles.patch ; rm tripleLayerMetatiles.patch

Repo

git remote add psf-expansion https://github.com/PokemonSanFran/pokeemerald-expansion/ ; git pull psf-expansion tripleLayerMetatiles

Manual Tests

After replicating the branch, to recreate my testing environment, you can either directly download the debug script and config file, or manually create the changes.

Download

wget https://files.catbox.moe/g9cspg.inc -O data/scripts/debug.inc ; wget https://files.catbox.moe/9yr2c2.sav -O pokeemerald.sav

Manual Testing

• Run the migration script
• Compile the game
• Complete a floor of the Battle Pyramid
• Open the Overworld Debug Menu
• Utilites > Warp to map warp> Map Group 0, Map 0, Warp 0
• Look at the player's reflection in the pond
• Walk into the Pokemart, try to buy an option
• Save the game
• Open Porymap
• Add some grass in front of the PetalburgCity PokeMart
• Change the PetalburgCity weather to WEATHER_FOG_HORIZONTAL
• Compile game
• Walk outside

Verified Scenarios

The video shows all the Manual Testing.

Part 1

part1.mp4

Part 2

part2.mp4

People who collaborated with me in this PR

This was originally written by by @huderlem. @Jaizu found a spelling error.

Discord Contact Info

I am pkmnsnfrn on Discord, and there is a discussion thread.