Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move battle anim arrays to C #5306

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

cawtds
Copy link

@cawtds cawtds commented Sep 1, 2024

Description

Moved the battle anim scripts arrays to C. Makes it less error-prone.

Discord contact info

.cawt

src/battle_anim.c Outdated Show resolved Hide resolved
@cawtds
Copy link
Author

cawtds commented Sep 1, 2024

I think it makes sense to also rename the script pointers. Any preference: gBattleAnim_Status_XXX, gBattleAnimStatus_XXX, gBattleAnim_Status_XXX? Or something else?

@AlexOn1ine
Copy link
Collaborator

I think it makes sense to also rename the script pointers. Any preference: gBattleAnim_Status_XXX, gBattleAnimStatus_XXX, gBattleAnim_Status_XXX? Or something else?

Personally I think gBattleAnimStatus_XXX is best

@cawtds
Copy link
Author

cawtds commented Sep 1, 2024

I think it makes sense to also rename the script pointers. Any preference: gBattleAnim_Status_XXX, gBattleAnimStatus_XXX, gBattleAnim_Status_XXX? Or something else?

Personally I think gBattleAnimStatus_XXX is best

Should i also change the Move script names, or would that be too instrusive?

@AlexOn1ine
Copy link
Collaborator

I think it makes sense to also rename the script pointers. Any preference: gBattleAnim_Status_XXX, gBattleAnimStatus_XXX, gBattleAnim_Status_XXX? Or something else?

Personally I think gBattleAnimStatus_XXX is best

Should i also change the Move script names, or would that be too instrusive?

I'm not sure. I don't think a lot of conflicts will come from here but unless someone else chimes in I would keep the names.

@AlexOn1ine AlexOn1ine self-assigned this Sep 1, 2024
@AlexOn1ine AlexOn1ine added the category: move animation Pertains to move animations label Sep 1, 2024
@AlexOn1ine AlexOn1ine merged commit 6e3ce9d into rh-hideout:upcoming Sep 4, 2024
1 check passed
@cawtds cawtds deleted the refactor-battle-anim-arrays branch September 4, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: move animation Pertains to move animations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants