Merrp merge (September 9th)

[AsparagusEduardo]

This is a merrp merge - DO NOT SQUASH!

Description

• Backported OBJ_EVENT_GFX_SPECIES macros from pokeemerald-expansion aarant/pokeemerald#40 (discarded, as it was already part of the expansion)
• feat: static OW pokemon now bob while walking in place (per OW_MON_BOBBING)
• feat: added OW_MON_WANDER_WALK config option

Discord contact info

AsparagusEduardo

[Bassoonian]

I'm personally conflicted on if the OW_FOLLOWERS_BOBBING rename should be in a PR that is otherwise a very strict sync

[AsparagusEduardo]

I'm personally conflicted on if the OW_FOLLOWERS_BOBBING rename should be in a PR that is otherwise a very strict sync

Hmm... can I at least add a comment saying that it applies to both followers and other overworld mon?

[Bassoonian]

I would personally leave the sync PRs as "pure" as they can be and just make a follow-up PR for the config rename. That way, we also have the syncing in the sync section in the changelog and the rename (which is expansion-related and has nothing to do with merrp's branch) elsewhere.

[AsparagusEduardo]

I would personally leave the sync PRs as "pure" as they can be and just make a follow-up PR for the config rename. That way, we also have the syncing in the sync section in the changelog and the rename (which is expansion-related and has nothing to do with merrp's branch) elsewhere.

Would brace adjustments also fall into these "impure" changes?

[Bassoonian]

They wouldn't imo because that is just plain conversion of something to match expansion (like making something actually build when it otherwise wouldn't), so I personally consider that a necessity. Renaming a config falls under a different category imo.

[AsparagusEduardo]

Got it. I'll force-push to undo the name change commit.

[AsparagusEduardo]

Ready!

[Bassoonian]

Some minor style remarks

[AsparagusEduardo]

Ready!