Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up a bit of code with GetBattlerPartyData #5378

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

AlexOn1ine
Copy link
Collaborator

@AlexOn1ine AlexOn1ine commented Sep 12, 2024

Closes #2656

The function was already present. I just renamed it to represent more what it does and cleaned up the code I could

@hedara90
Copy link
Collaborator

I don't know if GetBattlerPartyData is the best name for the function. To me is sounds like it would return a reference to a party (Pokemon array) instead of a reference to a single Pokemon.

@AlexOn1ine
Copy link
Collaborator Author

I don't know if GetBattlerPartyData is the best name for the function. To me is sounds like it would return a reference to a party (Pokemon array) instead of a reference to a single Pokemon.

so keep the old name?

@hedara90
Copy link
Collaborator

Yea, more descriptive of what it does

@AlexOn1ine
Copy link
Collaborator Author

Would GetPartyBattlerData work better? I see how the current name is confusing but I think it would be good to have a reference to party because it is the job of the function.

@hedara90
Copy link
Collaborator

Would GetPartyBattlerData work better? I see how the current name is confusing but I think it would be good to have a reference to party because it is the job of the function.

That works

@hedara90 hedara90 self-assigned this Sep 14, 2024
@AlexOn1ine
Copy link
Collaborator Author

ready for review again

@hedara90 hedara90 merged commit 25e9ca2 into rh-hideout:upcoming Sep 15, 2024
1 check passed
@AlexOn1ine AlexOn1ine deleted the GetBattlerPartyData branch November 21, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants