Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Neutralizing Gas crashes + adds missing interaction, Regenerator small fix #5694

Merged

Conversation

PhallenTree
Copy link

@PhallenTree PhallenTree commented Nov 20, 2024

  • Fixed Neutralizing Gas crashes similar to Game crashes when Neutralizing Gas mon is switched out vs Intimidate mon #4627 when using Baton Pass, Eject Button/Pack, phasing moves, Healing Wish with pre-Gen 4 settings (happen due to gBattlerAttacker and gBattleScripting.battler being overwritten while trying to do other battler's switchin abilities)

  • Added missing "Neutralizing Gas leaves the field" interactions if the battler with Neutralizing Gas fainted.

  • Fixed Regenerator sometimes taking 1/3rd of the wrong battler's max HP.

Discord contact info

PhallenTree

@hedara90 hedara90 added category: battle-mechanic Pertains to battle mechanics bugfix Bugfixes labels Nov 20, 2024
@AlexOn1ine
Copy link
Collaborator

Added missing "Neutralizing Gas leaves the field" interactions if the battler with Neutralizing Gas fainted.

what's the interaction?

@PhallenTree
Copy link
Author

PhallenTree commented Nov 20, 2024

My bad, it wasn't a missing interaction, a BattleScript_NeutralizingGasExits was missing for whenever a battler with Neutralizing Gas fainted, causing all other abilities to become active (in particular, to allow switchin abilities to trigger)

test/battle/ability/intimidate.c Show resolved Hide resolved
test/battle/ability/intimidate.c Show resolved Hide resolved
test/battle/ability/intimidate.c Show resolved Hide resolved
@AlexOn1ine AlexOn1ine merged commit 596b8b2 into rh-hideout:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants