Removes Resource Flags and moves fields to DisableStruct

[AlexOn1ine]

The ResourceFlags struct was unreasonably convoluted. I've moved everything to the DisbaleStruct and removed it so it isn't used anymore.

[AsparagusEduardo]

I remember seeing end of word messages earlier. Did they get deleted in the merge with upcoming?

[AlexOn1ine]

I remember seeing end of word messages earlier. Did they get deleted in the merge with upcoming?

I deleted it after #5946 because it looked weird. I can bring it back but I would argue that it would need a comment when the word starts and ends so it isn't mixed up with other fieds.

[AsparagusEduardo]

I deleted it after #5946 because it looked weird. I can bring it back but I would argue that it would need a comment when the word starts and ends so it isn't mixed up with other fieds.

Maybe instead of a "word start", a newline would be better?

[AlexOn1ine]

I deleted it after #5946 because it looked weird. I can bring it back but I would argue that it would need a comment when the word starts and ends so it isn't mixed up with other fieds.

Maybe instead of a "word start", a newline would be better?

oh that's a good idea

[AlexOn1ine]

let me know if this is okay.

to cut down on end of word usage we can also use u32's instead. Not sure if this is a good idea though

[AsparagusEduardo]

let me know if this is okay.

to cut down on end of word usage we can also use u32's instead. Not sure if this is a good idea though

A word is 4 bytes (u32), not 1 byte u8 ^^;

[AlexOn1ine]

let me know if this is okay.
to cut down on end of word usage we can also use u32's instead. Not sure if this is a good idea though

A word is 4 bytes (u32), not 1 byte u8 ^^;

Fixed

[AsparagusEduardo]

Fixed

Oh. I thought you were going to split it by word.
Hmm, I'm not sure if I like it being split by byte, as the whole point of those comments is to know when the struct is being padded to 4bytes.

[AlexOn1ine]

Fixed

Oh. I thought you were going to split it by word. Hmm, I'm not sure if I like it being split by byte, as the whole point of those comments is to know when the struct is being padded to 4bytes.

will do

[AlexOn1ine]

Suggestion to revert the end of byte marks and do the reordering in a new pr.

[AsparagusEduardo]

Suggestion to revert the end of byte marks and do the reordering in a new pr.

Sure 👍

[AlexOn1ine]

ready for re-review

[AsparagusEduardo]

ready for re-review

Sorry, last master->upcoming merge added a conflict 🙏

[AlexOn1ine]

ready for re-review

Sorry, last master->upcoming merge added a conflict 🙏

solved