Restore lock/lockall/locktrainer/release/releaseall in triggers #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how can this be tested? |
|
Annoyingly the answer is just "walk/run into triggers in-game and check they behave like in vanilla". Work's looking really busy atm and likely to bleed into my free time, but I'll report back if I find the time to do it :) |
mrgriffin
force-pushed
the
rhh-rollback-mapscript
branch
from
07e9992 to
5f67718
Compare
mrgriffin
force-pushed
the
rhh-rollback-mapscript
branch
from
5f67718 to
a96a570
Compare
mrgriffin
added
the
type: big feature
|
HunarPG found some problems that I need to fix:
|
|
DizzyEggg
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5033 caused some weirdness with
lock*andrelease*commands in triggers. This PR should restore the behavior, but it needs some testing :)Reported by AGSMGMaster64. Testing by HunarPG.