Add caught mon to full party by sending a different mon to the Box

[fakuzatsu]

Allows you to switch a caught Pokemon into your party even when it is full. Similar to how modern games work.

(Doesn't come with all the other stuff shown in the gif, that's just on my personal romhack)

[fakuzatsu]

I've clearly fucked something up in regards to the compound string stuff. That's all newer than the version I'd originally developed the feature on. Will sort out soon.

[fakuzatsu]

fixed, ready for review

[AlexOn1ine]

not a review but could you use enums for the cases for documentation?

[Bassoonian]

There doesn't appear to be a config here, which is pretty vital for something like this. The current (original Emerald) behaviour should be easily toggleable.

[AlexOn1ine]

To remember to close it once this is merged, closes #3912

[AlexOn1ine]

@fakuzatsu Sorry, but one more request. Could you add a config that prevents for choosing mons that know an HM? 😅

[fakuzatsu]

I'll give it a stab, I imagine it'll be easy to prevent picking a mon with a HM, but not so much to display an error due to trying.

[AlexOn1ine]

I'll give it a stab, I imagine it'll be easy to prevent picking a mon with a HM, but not so much to display an error due to trying.

Thx. I think it would be fine if it is just blocked.

[fakuzatsu]

Ok, sorted. I managed to get a message displayed to the effect of "Cannot send that mon because it knows a HM", and it's behind a config that's set to TRUE by default.

One thing to note is that I've replicated some static data from the pokemon.c file so that I could customise the function rather than adding a new arg or anything like that. I think really the most optimal solution to this would have been to create a global DoesMonKnowAHM function, but I won't be handling that in this PR.