Updated Trainer Ids used in Trainer Slides tests

[pkmnsnfrn]

Description

@AlexOn1ine discovered an issue where Trainer Slides were being executed in non-Trainer slide tests, despite the Trainer Slide tests using specific Trainer Ids for each test.

This was occuring because TRAINER_SLIDE_BEFORE_FIRST_TURN is the same value as TRAINER_NONE (the default Trainer Id for tests). "Before First Turn" always triggers before the first turn, so this would always run.

This changes the Trainer IDs used in tests to start at a value higher than TRAINER_NONE.

Images

People who collaborated with me in this PR

@AlexOn1ine found the original bug, @AsparagusEduardo confirmed it

Discord contact info

pkmnsnfrn
Discussion was here: https://discord.com/channels/419213663107416084/1077009799293710357/1334184936596574359

[AsparagusEduardo]

Just now checking this. Wouldn't it be better to update the enum itself by adding a TRAINER_SLIDE_NONE?

[pkmnsnfrn]

Just now checking this. Wouldn't it be better to update the enum itself by adding a TRAINER_SLIDE_NONE?

I was originally going to do that, but it would waste some bits in gBattleStruct since that slide would never get used.

[AsparagusEduardo]

I was originally going to do that, but it would waste some bits in gBattleStruct since that slide would never get used.

Why do you need to use bits in gBattleStruct for it in the first place? 🤔

Just did it locally without adding any bits and it works fine.