CanAbilityX Function Cleanup #6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 3, 2025 08:51
ghoulslash
added
category: battle-mechanic
AlexOn1ine
reviewed
Feb 4, 2025
AlexOn1ine
reviewed
Feb 5, 2025
added 3 commits
February 5, 2025 09:03
AlexOn1ine
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanAbilityBlockMove/CanAbilityAbsorbMove were introduced in 1.10.0 and are really nice for syncing code between AI and actual battle engine computations. This PR adds a "runScript" function to each of these to further reduce the overhead of AbilityBattleEffects. It also moves CanPartnerAbilityBlockMove into CanAbilityBlockMove