Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put url parameters outside of erb on paths resolve #202

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

adie
Copy link
Contributor

@adie adie commented Sep 13, 2016

Original problem was with fontawesome, with rake bower:resolve, bower-rails was generating urls like

  src: url(<%= asset_path 'fontawesome/fonts/fontawesome-webfont.eot?v=4.4.0' %>);

And when we tried to manually compile assets from code in production - Rails was trying to fetch that exact string from assets.digest instead of just 'fontawesome/fonts/fontawesome-webfont.eot' - and we were getting AssetNotPrecompiledError
Essentially this PR just changes bower-rails to generate such urls as

  src: url(<%= asset_path 'fontawesome/fonts/fontawesome-webfont.eot' %>?v=4.4.0);

@coveralls
Copy link

coveralls commented Sep 13, 2016

Coverage Status

Coverage increased (+3.2%) to 90.985% when pulling 98451ad on Fuseit:fix-css-paths-with-params into 874142c on rharriso:master.

@SergeyKishenin
Copy link
Collaborator

Thanks!

@SergeyKishenin SergeyKishenin merged commit 15a9d87 into rharriso:master Sep 14, 2016
SergeyKishenin added a commit that referenced this pull request Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants