lds: remove note.gnu.build-id from most places, move to the end. #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.note.gnu.build-id was included in rodata sections on some architectures, which get added to the elf .so & debug .so, but are not copied into pe binary. Unless of course this section was embeeded inside the .rodata. Remove embedded copies of build-id, move build-id to the end of the elf binaries. Note that stability and reproducibility of build-id note is not needed, as most distributions strip & replace build-id with a rebuilt one based on package name & version. Fixes rhboot#366 (point 2) Signed-off-by: Dimitri John Ledkov <[email protected]>
|
Settings this to draft, as that's just a concept. Did not compiler or test boot this yet on all the arches. In theory this change should not result in change of the pe binaries, or make them reproducible. |
|
Closing this since it's been untouched for a year. |
|
This is still needed, because without this change the builds of shim end up being non-reproducible which harms shim review. |
|
That's fine, but it sat in draft for a year without changes. Per your comment: "Settings this to draft, as that's just a concept. Did not compiler or test boot this yet on all the arches.", so feel free to reopen if that changes or you need to run against CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.note.gnu.build-id was included in rodata sections on some
architectures, which get added to the elf .so & debug .so, but are not
copied into pe binary. Unless of course this section was embeeded
inside the .rodata.
Remove embedded copies of build-id, move build-id to the end of the
elf binaries. Note that stability and reproducibility of build-id note
is not needed, as most distributions strip & replace build-id with a
rebuilt one based on package name & version.
Fixes #366 (point 2)
Signed-off-by: Dimitri John Ledkov [email protected]