Apply the EKU checks #661
Closed
Apply the EKU checks #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the CodeSign EKU check to fulfill the requirements of NIAP OS_PP. Also modify the ModSign EKU check to use VerifyEKUsInPkcs7Signature() to check the signer certificate instead of the certificate directly from the key database. The EKU check can be enabled by setting ENABLE_EKU_CODESIGN=1 when make. This commit supercedes PR-232 which was closed on Jul 1, 2021. Signed-off-by: Gary Lin <[email protected]> and Dennis Tseng <[email protected]>
|
To not change the original author's commit, this PR will be closed and replaced by PR#664 (Apply EKU check with compile option). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the CodeSign EKU check to fulfill the requirements of NIAP OS_PP. Also modify the ModSign EKU check to use VerifyEKUsInPkcs7Signature() to check the signer certificate instead of the certificate directly from the key database.
The EKU check can be enabled by setting ENABLE_EKU_CODESIGN=1 when make. This commit supersedes PR-232 which was closed on Jul 1, 2021.
Signed-off-by: Gary Lin [email protected] and
Dennis Tseng [email protected]