Skip to content

Commit

Permalink
Use explicit dynamic over void return types (flutter#99)
Browse files Browse the repository at this point in the history
Some implementations are relying on passing values through the visit
methods. Make return types explicitly `dynamic` to match their implicit
types from before.

This highlights that extending the `Visitor` class and expecting to return
useful values is inherently risky. Not only will usages fall through to dynamic
and have no static errors for things like typos, there are also places where
the values will be silently discarded by the implementation in` Visitor`.
  • Loading branch information
natebosch authored Jan 2, 2020
1 parent c9528fc commit 75a88e8
Show file tree
Hide file tree
Showing 3 changed files with 302 additions and 295 deletions.
Loading

0 comments on commit 75a88e8

Please sign in to comment.