Add kernel info and timezone info #127
Conversation
|
/lgtm |
|
@lukas-bednar please approve |
| out = self._exec_command( | ||
| cmd=cmd, err_msg="Failed to obta kernel info" | ||
| ) | ||
| Kernel = namedtuple('Kernel', values) |
There was a problem hiding this comment.
made it from capital just to be aligned with already existing code (see Distribution in get_distribution method)
There was a problem hiding this comment.
This is wrong, but I guess @lukas-bednar should decide.
There was a problem hiding this comment.
I believe this is alright. namedtuple returns a class, and then you create instance of that class. And classes in python should be Uppercased.
| out = self._exec_command( | ||
| cmd=cmd, err_msg="Failed to obtain timezone info" | ||
| ) | ||
| Timezone = namedtuple('Timezone', values) |
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 79.54% 79.78% +0.24%
==========================================
Files 19 19
Lines 1843 1865 +22
==========================================
+ Hits 1466 1488 +22
Misses 377 377
Continue to review full report at Codecov.
|
tests/test_os.py
Outdated
| @@ -95,6 +110,8 @@ class TestOperatingSystemNegative(object): | |||
| ), | |||
| 'python -c "import platform;print(\',\'.join(' | |||
| 'platform.linux_distribution()))"': (1, '', 'SyntaxError'), | |||
| 'uname -r ; uname -v ; uname -m': (1, '', 'SyntaxError'), | |||
There was a problem hiding this comment.
I don't think that uname or date command can raise any SyntaxError , so I believe that these tests are redundant here.
You can either remove them, or think about something more likely happening for these two commands.
|
LGTM |
Add kernel (release, version, type) and timezone (name, offset) info.