-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests for python 3.11 #4216
Fix unit tests for python 3.11 #4216
Conversation
@hroncok, if you can please take a look, I would be grateful. I'll admit I don't really understand the "why" of this, just that eliminating some of the If by chance you have any ideas about pylint/dill, I'm all ears too. My understanding is that we are waiting for their release that is compatible with the Python betas. |
/kickstart-test --testtype smoke |
Is this by any chance an enum? That is a deliberate backward-incompatible change by the enum maintainer. See for example: python/cpython#87328 |
About pylint: I don't recommend running linters on not yet released Python versions. |
Yes, it's an enum. Thank you for the information, as well as pushing to make this visible. (I did read the what's new pretty carefully...)
Well, is it an option to just not take Rawhide's last Python? It doesn't feel that way from here. |
It does not work well with Python 3.11.
/kickstart-test --testtype smoke |
I don't know what are you doing (or trying to achieve), so I cannot answer your question.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you.
With this, unit tests can succeed.
Pylint is not fixed - its most current breakage is due to interface changes in the new Python disagreeing with
dill
, whatever that is. See uqfoundation/dill#514 and uqfoundation/dill#480. Note that this PR does not change anything requiring rebuild of containers, so pylint appears to work here, but it's just stale container being used.