Handle invalid UTF-8 characters in efibootmgr output #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Hello @KKoukiou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2025-01-08 16:58:07 UTC |
KKoukiou
force-pushed
the
efibootmgr-nonutf8-tempfix
branch
from
cacb137 to
df3b972
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
force-pushed
the
efibootmgr-nonutf8-tempfix
branch
from
df3b972 to
a16d4f8
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
@nfrayer can you please share you opinion on this. |
|
@M4rtinK seemingly efibootmgr does not promise to return utf-8 only chars. https://bugzilla.redhat.com/show_bug.cgi?id=2292493#c21 So I guess it's fine to introduce this fix. |
KKoukiou
force-pushed
the
efibootmgr-nonutf8-tempfix
branch
from
a16d4f8 to
d22483b
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Agreed, lets use this fix then & thanks for digging deeper into this, its good to have some context. :) |
M4rtinK
approved these changes
Jan 2, 2025
KKoukiou
force-pushed
the
efibootmgr-nonutf8-tempfix
branch
from
d22483b to
46f3ce5
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
force-pushed
the
efibootmgr-nonutf8-tempfix
branch
from
46f3ce5 to
6dea007
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Modified the code to handle invalid UTF-8 characters in the output of the efibootmgr command by using `errors="replace"`. This prevents decode exceptions when encountering non-UTF-8 sequences in the EFI boot manager output [1]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=2292493#c21 Resolves: rhbz#2254801
KKoukiou
force-pushed
the
efibootmgr-nonutf8-tempfix
branch
from
6dea007 to
816f494
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
@M4rtinK can you please re-review? |
|
/kickstart-tests --testtype uefi |
|
/kickstart-tests --testtype smoke |
M4rtinK
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the code to handle invalid UTF-8 characters in the output of the efibootmgr command by
using
errors="replace". This prevents decode exceptions when encountering non-UTF-8 sequencesin the EFI boot manager output [1].
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2292493#c21
Resolves: rhbz#2254801