Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ketama sync #342

Merged
merged 18 commits into from
Sep 30, 2022
Merged

Ketama sync #342

merged 18 commits into from
Sep 30, 2022

Conversation

philipgough
Copy link
Contributor

Rebase ketama branch on main

matej-g and others added 18 commits September 15, 2022 15:54
* Fix memcached overview dashboard

Signed-off-by: Matej Gera <[email protected]>

* Sync whitelist

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Rename thanos-rule-syncer metrics port 

Signed-off-by: Jéssica Lins <[email protected]>
* Add Rules & alerting SLOs panels
* Add Telemeter SLOs
* Remove unnecessary comment
* Use rate for SLO query about alerts being delivered to upstream targets
* Update rules sync SLO query
* Add alerts for Rules and Alerting SLOs
* Add container selector to APIRulesSyncAvailabilityErrorBudgetBurning alert
* Fix telemeter namespace, update sync SLO query in alerts
* Refactor instanceNamespace function

Signed-off-by: Jéssica Lins <[email protected]>
SLOs: Prune unsupported labels (rhobs#325)

Signed-off-by: Jéssica Lins <[email protected]>
* Fix SLO alerting for metrics

Signed-off-by: Saswata Mukherjee <[email protected]>

* Add back code labels to exclude 4xx

Signed-off-by: Saswata Mukherjee <[email protected]>

* Add comment about fork

Signed-off-by: Saswata Mukherjee <[email protected]>

Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>

Signed-off-by: Saswata Mukherjee <[email protected]>
Note, this is a breakinbg change which requires the use
of Thanos >= v0.28.0
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@philipgough philipgough merged commit 94cc99a into rhobs:ketama Sep 30, 2022
@philipgough philipgough deleted the ketama-patch branch September 30, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants