-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ketama sync #342
Merged
Merged
Ketama sync #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix memcached overview dashboard Signed-off-by: Matej Gera <[email protected]> * Sync whitelist Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Matej Gera <[email protected]>
Rename thanos-rule-syncer metrics port Signed-off-by: Jéssica Lins <[email protected]>
* Add Rules & alerting SLOs panels * Add Telemeter SLOs * Remove unnecessary comment * Use rate for SLO query about alerts being delivered to upstream targets * Update rules sync SLO query
* Add alerts for Rules and Alerting SLOs * Add container selector to APIRulesSyncAvailabilityErrorBudgetBurning alert * Fix telemeter namespace, update sync SLO query in alerts * Refactor instanceNamespace function Signed-off-by: Jéssica Lins <[email protected]>
SLOs: Prune unsupported labels (rhobs#325) Signed-off-by: Jéssica Lins <[email protected]>
* Fix SLO alerting for metrics Signed-off-by: Saswata Mukherjee <[email protected]> * Add back code labels to exclude 4xx Signed-off-by: Saswata Mukherjee <[email protected]> * Add comment about fork Signed-off-by: Saswata Mukherjee <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Douglas Camata <[email protected]>
Note, this is a breakinbg change which requires the use of Thanos >= v0.28.0
douglascamata
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase ketama branch on
main