Disable compression on receive #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <[email protected]>
|
I wonder do we want to make this a parameter with the default value of none for future proofing? Saying that I'm ok with this directly for now |
philipgough
approved these changes
Oct 5, 2022
I think we can cross that bridge when we come to it 👍 |
matej-g
added a commit
to matej-g/configuration
that referenced
this pull request
Oct 5, 2022
Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Matej Gera <[email protected]>
matej-g
added a commit
that referenced
this pull request
Oct 5, 2022
* Update README (#343) * Update README - Added instructions for macOS - Fixed jsonnet deps command Signed-off-by: Douglas Camata <[email protected]> * Update OpenShift templates doc link Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Douglas Camata <[email protected]> * Disable compression on receive (#346) Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Matej Gera <[email protected]> Co-authored-by: Douglas Camata <[email protected]>
philipgough
pushed a commit
to philipgough/configuration
that referenced
this pull request
Oct 10, 2022
* Update README (rhobs#343) * Update README - Added instructions for macOS - Fixed jsonnet deps command Signed-off-by: Douglas Camata <[email protected]> * Update OpenShift templates doc link Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Douglas Camata <[email protected]> * Disable compression on receive (rhobs#346) Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Matej Gera <[email protected]> Co-authored-by: Douglas Camata <[email protected]>
philipgough
pushed a commit
to philipgough/configuration
that referenced
this pull request
Oct 10, 2022
* Update README (rhobs#343) * Update README - Added instructions for macOS - Fixed jsonnet deps command Signed-off-by: Douglas Camata <[email protected]> * Update OpenShift templates doc link Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Douglas Camata <[email protected]> * Disable compression on receive (rhobs#346) Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Matej Gera <[email protected]> Co-authored-by: Douglas Camata <[email protected]>
philipgough
added a commit
that referenced
this pull request
Oct 10, 2022
* Add Rules and Alertmanager SLOs (#298) * Add Rules & alerting SLOs panels * Add Telemeter SLOs * Remove unnecessary comment * Use rate for SLO query about alerts being delivered to upstream targets * Update rules sync SLO query * Add alerts for Rules and Alerting SLOs (#300) * Add alerts for Rules and Alerting SLOs * Add container selector to APIRulesSyncAvailabilityErrorBudgetBurning alert * Fix telemeter namespace, update sync SLO query in alerts * Refactor instanceNamespace function Signed-off-by: Jéssica Lins <[email protected]> * SLOs: Prune unsupported labels (#325) SLOs: Prune unsupported labels (#325) Signed-off-by: Jéssica Lins <[email protected]> * [observatorium-logs] Increase the querier timeout from 3m to 6m (#330) * Fix SLO alerting for metrics (#328) * Fix SLO alerting for metrics Signed-off-by: Saswata Mukherjee <[email protected]> * Add back code labels to exclude 4xx Signed-off-by: Saswata Mukherjee <[email protected]> * Add comment about fork Signed-off-by: Saswata Mukherjee <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]> * Add OSD to rules-obsctl-reloader (#329) Signed-off-by: Saswata Mukherjee <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]> * Add Loki ruler and static rules for tenant OCM (#331) * Fix loki ruler memory requests (#332) * Fix ocm panic logs-based alert (#333) * Remove recycle annotations for loki rules (#334) * Add staging test alerts for rhobs logs (#335) * Fix alertmanager discovery for logs ruler (#338) * Use alertmanager v1 api for Loki ruler (#339) * Update Telemeter rules (#340) Signed-off-by: Douglas Camata <[email protected]> * Fix ARM64 (M1 Pro) support (#344) * Update Bingo Signed-off-by: Douglas Camata <[email protected]> * Update Bingo deps for aarm64 support Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Douglas Camata <[email protected]> * Add suppport for Loki ruler to manage rules on object storage (#345) * Add template for Loki ruler CRDs (#349) * Add /rules/raw row to Observatorium API dashboard + refactor (#337) * Refactor titleRow * Refactor query row * Refactor query_range row * Start refactor RED for all row * Refactor all query err * Refactor query duration * Refactor titleRow * Finish refactor * Start to add /rules/raw row * Fix positioning, finish rules row * Remove unused var * sum by code for errors panel * Unify aliasColors * Fix errors query, use scalar Signed-off-by: Jéssica Lins <[email protected]> * Fix Updating dashboards README section (#351) Signed-off-by: Jéssica Lins <[email protected]> * Add obsctl-reloader support for Loki alerting- and recordingrules (#352) * Add cluster-role observatorium-logs-edit for dedicated-admins (#353) * Add dedicated-admin label for obs-logs-edit clusterrole (#354) * Enable hashing algorithm for receive to be set via parameter Note, this is a breakinbg change which requires the use of Thanos >= v0.28.0 * Ketama sync to main (#347) * Update README (#343) * Update README - Added instructions for macOS - Fixed jsonnet deps command Signed-off-by: Douglas Camata <[email protected]> * Update OpenShift templates doc link Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Douglas Camata <[email protected]> * Disable compression on receive (#346) Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Matej Gera <[email protected]> Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Matej Gera <[email protected]> Co-authored-by: Douglas Camata <[email protected]> Signed-off-by: Jéssica Lins <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]> Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Matej Gera <[email protected]> Co-authored-by: Jéssica Lins <[email protected]> Co-authored-by: Periklis Tsirakidis <[email protected]> Co-authored-by: Saswata Mukherjee <[email protected]> Co-authored-by: Douglas Camata <[email protected]> Co-authored-by: Matej Gera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matej Gera [email protected]
Since
0.28.0, receiver uses snappy compression for gRPC requests by default (thanos-io/thanos#5575 (comment)). However, we noticed in our case this leads to an increased memory consumption on receiver replicas, especially in Telemeter where the requests are bigger (contain more series). Since we're better of with no compression / less memory overhead in our case, I'm disabling it.