chore: new file-based-catalog based on 0.0.13 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
requested review from
slashpai and
JoaoBraveCoding
and removed request for
a team
sthaha
changed the title
sthaha
added a commit
to sthaha/observability-operator
that referenced
this pull request
Sep 16, 2022
The Catalog index yaml file for the new file-based catalog will be
maintained in the olm-catalog branch. The PR introduces the changes
needed to generate new catalog index entry for new releases to the
development, candidate, and the stable channel and to push the updated
index to the olm-catalog git branch.
To switch to new file-based OLM catalogs, following changes have been made
* upgrade to newer version of operator-sdk tools (operator-sdk, olm)
* Generate catalog for existing 0.0.13 bundle by
* creating new catalog index dockerfile
* adding package definition for observability-operator
* adding channel definitions for all 3 channels
see: rhobs#194
* Modify GitHub workflow to adapt to the new file-based catalog
JIRA: https://issues.redhat.com/browse/MON-2791
Signed-off-by: Sunil Thaha <[email protected]>
This was referenced Sep 16, 2022
sthaha
added a commit
to sthaha/observability-operator
that referenced
this pull request
Sep 16, 2022
The Catalog index yaml file for the new file-based catalog will be
maintained in the olm-catalog branch. The PR introduces the changes
needed to generate new catalog index entry for new releases to the
development, candidate, and the stable channel and to push the updated
index to the olm-catalog git branch.
To switch to new file-based OLM catalogs, following changes have been made
* upgrade to newer version of operator-sdk tools (operator-sdk, olm)
* Generate catalog for existing 0.0.13 bundle by
* creating new catalog index dockerfile
* adding package definition for observability-operator
* adding channel definitions for all 3 channels
see: rhobs#194
* Modify GitHub workflow to adapt to the new file-based catalog
JIRA: https://issues.redhat.com/browse/MON-2791
Signed-off-by: Sunil Thaha <[email protected]>
jan--f
requested changes
Sep 20, 2022
olm/update-channels.sh
Outdated
Comment on lines
43
to
44
| local channels=$1; shift | ||
| local bundle=$1; shift |
There was a problem hiding this comment.
Suggested change
| local channels=$1; shift | |
| local bundle=$1; shift | |
| local channels="$1"; shift | |
| local bundle="$1"; shift |
There was a problem hiding this comment.
Thanks, I have fixed and updated the commit.
| @@ -8,6 +8,7 @@ IMAGE_BASE ?= observability-operator | |||
|
|
|||
| VERSION ?= $(shell cat VERSION) | |||
| OPERATOR_IMG = $(IMAGE_BASE):$(VERSION) | |||
| OPERATOR_BUNDLE=observability-operator.v$(VERSION) | |||
There was a problem hiding this comment.
Suggested change
| OPERATOR_BUNDLE=observability-operator.v$(VERSION) | |
| OPERATOR_BUNDLE=observability-operator-v$(VERSION) |
Isn't this a more common way of adding a version to the name? I went looking for examples and found https://olm.operatorframework.io/docs/best-practices/channel-naming/ which also seems to suggest name-version. Might be less surprising for anyone who tries to parse this?
There was a problem hiding this comment.
I am a bit confused about this comment.
We aren't changing the existing channel names stable, candidate, development in this patch.
If it is about the change proposed, that wouldn't work since opm render <bundle-image> uses the format in PR. E.g.
❯ opm render quay.io/rhobs/observability-operator-bundle:0.0.13 --output=yaml | ag '^name:'
name: observability-operator.v0.0.13
There was a problem hiding this comment.
Got it. I just pointed it out cause the name format looked odd to me. But since its not under our control I'll merge this.
This PR creates a new file-based OLM catalog index based on 0.0.13 bundle that is already published to quay.io This is achieved by running ``` make catalog-image VERSION=0.0.13 IMAGE_BASE=quay.io/rhobs/observability-operator ``` Signed-off-by: Sunil Thaha <[email protected]>
sthaha
added a commit
to sthaha/observability-operator
that referenced
this pull request
Sep 20, 2022
The Catalog index yaml file for the new file-based catalog will be
maintained in the olm-catalog branch. The PR introduces the changes
needed to generate new catalog index entry for new releases to the
development, candidate, and the stable channel and to push the updated
index to the olm-catalog git branch.
To switch to new file-based OLM catalogs, following changes have been made
* upgrade to newer version of operator-sdk tools (operator-sdk, olm)
* Generate catalog for existing 0.0.13 bundle by
* creating new catalog index dockerfile
* adding package definition for observability-operator
* adding channel definitions for all 3 channels
see: rhobs#194
* Modify GitHub workflow to adapt to the new file-based catalog
JIRA: https://issues.redhat.com/browse/MON-2791
Signed-off-by: Sunil Thaha <[email protected]>
jan--f
pushed a commit
that referenced
this pull request
Sep 20, 2022
The Catalog index yaml file for the new file-based catalog will be
maintained in the olm-catalog branch. The PR introduces the changes
needed to generate new catalog index entry for new releases to the
development, candidate, and the stable channel and to push the updated
index to the olm-catalog git branch.
To switch to new file-based OLM catalogs, following changes have been made
* upgrade to newer version of operator-sdk tools (operator-sdk, olm)
* Generate catalog for existing 0.0.13 bundle by
* creating new catalog index dockerfile
* adding package definition for observability-operator
* adding channel definitions for all 3 channels
see: #194
* Modify GitHub workflow to adapt to the new file-based catalog
JIRA: https://issues.redhat.com/browse/MON-2791
Signed-off-by: Sunil Thaha <[email protected]>
Signed-off-by: Sunil Thaha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new file-based OLM catalog index based on 0.0.13 bundle
that is already published to quay.io
This is achieved by running
Signed-off-by: Sunil Thaha [email protected]