Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JSON Ajax feed type, random feed order and general improvements #77

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Umaroth
Copy link

@Umaroth Umaroth commented May 5, 2017

New options:

  • feedType: 'json'
  • jsonType: 'array', 'object'
  • jsonObjKey: string matching which key you want to return from the object
  • order: 'sequential', 'random'
  • offset: number of pixels, default is 20

jsonType only must be set if feedType == 'json'
jsonObjKey only must be set if jsonType == 'object'

General code improvements:

  • Changed deprecated .live() function to .on()
  • Replaced implicit variable declarations with explicit ones
  • Removed unnecessary semicolons
  • Uniformly converted preceding spaces into tabs
  • Removed following empty space
  • Changed all comparisons to strict
  • Fixed broken comparison
  • Added error callbacks to ajax calls

Umaroth added 6 commits May 5, 2017 19:12
…ments

General code improvements:
-Removed implicit variable declarations
-Uniformed preceding spaces into tabs
-Removed unnecessary semicolons
-Changed all comparisons to strict
-Removed following empty space
-Fixed broken comparison
Added JSON Ajax feed type, random feed order and general improvements
-Added error callbacks to ajax calls
-Moved two variables to correct function and changed to explicit declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants