Skip to content

Commit

Permalink
Fix missing paranthesis closure for the clip-path and filter URLs
Browse files Browse the repository at this point in the history
  • Loading branch information
mthh committed Oct 11, 2022
1 parent 80cba97 commit 0b9ea13
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 15 deletions.
6 changes: 3 additions & 3 deletions src/layers/geolines.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export function geolines(selection, projection, planar, options = {}, clipid) {

selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.selectAll("path")
.data(eq)
.join("path")
Expand All @@ -60,7 +60,7 @@ export function geolines(selection, projection, planar, options = {}, clipid) {

selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.selectAll("path")
.data(tr)
.join("path")
Expand All @@ -74,7 +74,7 @@ export function geolines(selection, projection, planar, options = {}, clipid) {

selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.selectAll("path")
.data(po)
.join("path")
Expand Down
2 changes: 1 addition & 1 deletion src/layers/graticule.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function graticule(selection, projection, planar, options = {}, clipid) {
step = Array.isArray(step) ? step : [step, step];
selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.append("path")
.datum(d3.geoGraticule().step(step))
.attr("d", d3.geoPath(projection))
Expand Down
4 changes: 2 additions & 2 deletions src/layers/inner.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function inner(selection, projection, options = {}) {

selection
.append("g")
.attr("clip-path", `url(#inner${id}`)
.attr("clip-path", `url(#inner${id})`)
.append("path")
.datum(merged)
.attr("fill", "none")
Expand All @@ -51,7 +51,7 @@ export function inner(selection, projection, options = {}) {
.attr("stroke-linejoin", "round")
.attr("stroke-opacity", fillOpacity)
.attr("stroke-width", thickness * 2)
.attr("filter", `url(#blur${id}`)
.attr("filter", `url(#blur${id})`)
.attr("d", d3.geoPath(projection));
}
}
4 changes: 2 additions & 2 deletions src/layers/minimap.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export function minimap({
.attr("stroke-opacity", geometries.strokeOpacity)
.attr("d", path)
.attr("transform", `translate(${x} ${y})`)
.attr("clip-path", `url(#extent_${clipid}`); // ICI
.attr("clip-path", `url(#extent_${clipid})`); // ICI

// Outline (stroke)

Expand Down Expand Up @@ -210,7 +210,7 @@ export function minimap({
selection
.append("g")
.append("path")
.attr("clip-path", `url(#clipminimap_${clipid}`)
.attr("clip-path", `url(#clipminimap_${clipid})`)
.datum(geojson)
.attr("fill", raise.fill)
.attr("fill-opacity", raise.fillOpacity)
Expand Down
2 changes: 1 addition & 1 deletion src/layers/missing.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function missing(selection, projection, options = {}, clipid) {

selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.selectAll("path")
.data(missing)
.join("path")
Expand Down
2 changes: 1 addition & 1 deletion src/layers/rhumbs.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function rhumbs(selection, width, height, clipid, options = {}) {

selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.selectAll("polyline")
.data(angles)
.enter()
Expand Down
2 changes: 1 addition & 1 deletion src/layers/shadow.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function shadow(selection, projection, geojson, clipid, options = {}) {

selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.append("path")
.datum(merged)
.attr("d", path)
Expand Down
2 changes: 1 addition & 1 deletion src/layers/simple.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export function simple(
if (figuration(geojson) == "l" || figuration(geojson) == "z") {
selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.selectAll("path")
.data(geojson.features)
.join("path")
Expand Down
2 changes: 1 addition & 1 deletion src/layers/tiles.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export function tiles(selection, width, height, projection, options = {}) {

selection
.append("g")
.attr("clip-path", `url(#tileclip_${id}`)
.attr("clip-path", `url(#tileclip_${id})`)
.selectAll("image")
.data(tile())
.join("image")
Expand Down
2 changes: 1 addition & 1 deletion src/layers/tissot.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function tissot(selection, projection, planar, options = {}, clipid) {
let step = options.step ? options.step : 10;
selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.append("path")
.datum(ts(step))
.attr("d", geoPath(projection))
Expand Down
2 changes: 1 addition & 1 deletion src/layers/waterlines.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function waterlines(

selection
.append("g")
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid}`)
.attr("clip-path", clipid == null ? `none` : `url(#clip_${clipid})`)
.selectAll("path")
.data(features)
.join("path")
Expand Down

0 comments on commit 0b9ea13

Please sign in to comment.