fix: remote svg icon not rendering (#408)

* docs(changeset): fix svg icon * fix(ui): fix RemoteSvgIcon rendering
riccardoperra · Dec 9, 2022 · 21746dc · 21746dc
1 parent 5822f2b
commit 21746dc
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/khaki-carpets-judge.md b/.changeset/khaki-carpets-judge.md
@@ -0,0 +1,5 @@
+---
+'@codeimage/ui': patch
+---
+
+fix svg icon
diff --git a/apps/codeimage/index.html b/apps/codeimage/index.html
@@ -4,7 +4,7 @@
   <meta charset='utf-8'>
   <meta name='theme-color'>
   <meta name='apple-mobile-web-app-status-bar-style' content='dark-content'>
-  <link rel='icon' href='/assets/favicon.svg' type='image/svg+xml'>
+  <link rel='icon' href='/assets/favicon.ico'>
   <link rel='preconnect' href='https://fonts.googleapis.com'>
   <link rel='preconnect' href='https://fonts.gstatic.com' crossorigin='anonymous'>
   <link rel='preload' href='/assets/codeimage-logo-blue-svg-v1.svg' as='image' type='image/svg+xml'>

diff --git a/apps/codeimage/public/assets/favicon.ico b/apps/codeimage/public/assets/favicon.ico
diff --git a/packages/ui/src/lib/primitives/Icon/SvgIcon.tsx b/packages/ui/src/lib/primitives/Icon/SvgIcon.tsx
@@ -10,11 +10,14 @@ export function SvgIcon(props: SvgIconProps): JSX.Element {
   const [local, others] = splitProps(props, ['class', 'children', 'viewBox']);
 
   return (
+    // eslint-disable-next-line solid/jsx-no-duplicate-props
     <svg
       xmlns="http://www.w3.org/2000/svg"
       fill="none"
       class={classes()}
       viewBox={local.viewBox}
+      // eslint-disable-next-line solid/no-innerhtml
+      innerHTML={props.innerHTML ?? undefined}
       {...others}
     >
       {props.children}