Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 - UI components with @solid-aria #268

Closed
7 of 12 tasks
riccardoperra opened this issue Jun 4, 2022 · 1 comment · Fixed by #288
Closed
7 of 12 tasks

🤖 - UI components with @solid-aria #268

riccardoperra opened this issue Jun 4, 2022 · 1 comment · Fixed by #288
Labels
dev-infra P2 This issue has medium priority wontfix This will not be worked on
Milestone

Comments

@riccardoperra
Copy link
Owner

riccardoperra commented Jun 4, 2022

Description

solid-aria is the newest SolidJS library that exports primitives to build suer accessible user interface.

This porting currently affect these components:

Implementation notes

Retrocomptibility with Rollup

With the newest implementation of rollup-plugin of Vanilla-extract, @codeimage/ui will be ported from a vite setup to Rollup in order to use the rollup-preset-solid package and supports in the future solid-start

Exports

Every new component must be in his own folder and must be exported in a index.tsx file. Since there is Vite in library mode enabled, each type exported outside must be import using the import type keywords

export {
Text,
textStyles,
useText,
type UseTextProps,
type TextProps,
} from './Text';

Styling

Examples of solid-aria show simple styling style attribute. Obviously in @codeimage/ui this is not possible, so every type of style must be made with vanilla-extract.

The recommended approaches are:

  • Recipes
  • Through vanilla-extract style function and data-attributes (solid-aria will automatically handle these)
@riccardoperra riccardoperra moved this to Todo in CodeImage Jun 4, 2022
@riccardoperra riccardoperra added the P2 This issue has medium priority label Jun 4, 2022
@riccardoperra riccardoperra added this to the M2 milestone Jun 4, 2022
@riccardoperra riccardoperra linked a pull request Jun 21, 2022 that will close this issue
5 tasks
Repository owner moved this from Todo to Done in CodeImage Jun 25, 2022
@riccardoperra riccardoperra reopened this Jun 25, 2022
Repository owner moved this from Done to In Progress in CodeImage Jun 25, 2022
@riccardoperra riccardoperra pinned this issue Jul 13, 2022
@riccardoperra riccardoperra unpinned this issue Oct 6, 2022
@stale
Copy link

stale bot commented Nov 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 16, 2022
@stale stale bot closed this as completed Nov 23, 2022
Repository owner moved this from In Progress to Done in CodeImage Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-infra P2 This issue has medium priority wontfix This will not be worked on
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant