Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): add @solid-aria/dialog integration #288

Merged
merged 6 commits into from
Jun 25, 2022
Merged

refactor(ui): add @solid-aria/dialog integration #288

merged 6 commits into from
Jun 25, 2022

Conversation

riccardoperra
Copy link
Owner

@riccardoperra riccardoperra commented Jun 21, 2022 •
edited
Loading

  • Refator Dialog component with solid-aria
  • Refactor ExportDialog with new dialog component
  • Close modal on click outside
  • Add transition
  • Fix Popover context when using OverlayProvider

@riccardoperra riccardoperra linked an issue Jun 21, 2022 that may be closed by this pull request
🤖 - UI components with @solid-aria #268
Closed
12 tasks
@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 9939393

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@codeimage/app Patch
@codeimage/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
codeimage ✅ Ready (Inspect) Visit Preview Jun 25, 2022 at 10:02AM (UTC)

@vercel vercel bot temporarily deployed to Preview June 21, 2022 22:20 Inactive
@riccardoperra riccardoperra mentioned this pull request Jun 21, 2022
Closed
12 tasks
@riccardoperra riccardoperra marked this pull request as ready for review June 21, 2022 22:20
@vercel vercel bot temporarily deployed to Preview June 22, 2022 20:37 Inactive
@vercel vercel bot temporarily deployed to Preview June 22, 2022 20:56 Inactive
@vercel vercel bot temporarily deployed to Preview June 25, 2022 09:58 Inactive
@vercel vercel bot temporarily deployed to Preview June 25, 2022 10:02 Inactive
@riccardoperra riccardoperra merged commit ba54a85 into main Jun 25, 2022
@riccardoperra riccardoperra deleted the 268-ui-components-with-solid-aria branch June 25, 2022 10:11
@github-actions github-actions bot mentioned this pull request Jun 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤖 - UI components with @solid-aria
1 participant
@riccardoperra