Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): improve custom editor theme api #214

Merged
merged 22 commits into from
May 4, 2022

Conversation

riccardoperra
Copy link
Owner

@riccardoperra riccardoperra commented Apr 24, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #58

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@riccardoperra riccardoperra linked an issue Apr 24, 2022 that may be closed by this pull request
4 tasks
@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2022

🦋 Changeset detected

Latest commit: e3ca614

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@codeimage/app Minor
@codeimage/theme Minor
@codeimage/config Major
@codeimage/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/riccardoperra/codeimage/8KEMudzdDgiLMRYdNTCfwEhRLecw
✅ Preview: https://codeimage-git-212-theme-api-improvements-riccardoperra.vercel.app

@riccardoperra riccardoperra force-pushed the 212-theme-api-improvements branch from 8cb3348 to 0b8568a Compare April 24, 2022 10:17
@vercel vercel bot temporarily deployed to Preview April 24, 2022 10:17 Inactive
@riccardoperra riccardoperra changed the base branch from main to next April 24, 2022 11:04
@riccardoperra riccardoperra added the next Issues or pull request to do in next branch (until 6th May) label Apr 24, 2022
@vercel
Copy link

vercel bot commented Apr 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
codeimage ✅ Ready (Inspect) Visit Preview May 4, 2022 at 7:32PM (UTC)

@vercel vercel bot temporarily deployed to Preview April 30, 2022 10:11 Inactive
@vercel vercel bot temporarily deployed to Preview April 30, 2022 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview April 30, 2022 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview April 30, 2022 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview April 30, 2022 20:12 Inactive
@riccardoperra riccardoperra force-pushed the 212-theme-api-improvements branch from f03ca56 to 81539c6 Compare May 2, 2022 18:23
@vercel vercel bot temporarily deployed to Preview May 2, 2022 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview May 2, 2022 20:57 Inactive
@vercel vercel bot temporarily deployed to Preview May 2, 2022 21:40 Inactive
@riccardoperra riccardoperra force-pushed the 212-theme-api-improvements branch from 55d267e to d2479bf Compare May 2, 2022 22:10
@vercel vercel bot temporarily deployed to Preview May 2, 2022 22:12 Inactive
@vercel vercel bot temporarily deployed to Preview May 3, 2022 20:34 Inactive
@riccardoperra riccardoperra force-pushed the 212-theme-api-improvements branch from 3f5093a to 1e64489 Compare May 3, 2022 21:04
@vercel vercel bot temporarily deployed to Preview May 3, 2022 21:05 Inactive
@vercel vercel bot temporarily deployed to Preview May 3, 2022 21:25 Inactive
@vercel vercel bot temporarily deployed to Preview May 3, 2022 21:34 Inactive
@vercel vercel bot temporarily deployed to Preview May 3, 2022 21:57 Inactive
@riccardoperra riccardoperra force-pushed the 212-theme-api-improvements branch from 2060137 to 6cc7306 Compare May 3, 2022 21:58
@vercel vercel bot temporarily deployed to Preview May 3, 2022 21:59 Inactive
@riccardoperra riccardoperra force-pushed the 212-theme-api-improvements branch from 21fef0a to 90e0642 Compare May 3, 2022 22:11
@vercel vercel bot temporarily deployed to Preview May 3, 2022 22:12 Inactive
@vercel vercel bot temporarily deployed to Preview May 3, 2022 22:23 Inactive
@vercel vercel bot temporarily deployed to Preview May 4, 2022 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview May 4, 2022 19:31 Inactive
@riccardoperra riccardoperra marked this pull request as ready for review May 4, 2022 19:32
@riccardoperra riccardoperra merged commit ef7caa3 into next May 4, 2022
@riccardoperra riccardoperra deleted the 212-theme-api-improvements branch May 4, 2022 19:32
@vercel vercel bot temporarily deployed to Preview May 4, 2022 19:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next Issues or pull request to do in next branch (until 6th May)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤖 - Theme API improvements
1 participant